Skip to content

feat(core): support more instance error types#278

Merged
QuentinBrosse merged 3 commits intoscaleway:masterfrom
QuentinBrosse:support-more-instance-errors
Dec 23, 2019
Merged

feat(core): support more instance error types#278
QuentinBrosse merged 3 commits intoscaleway:masterfrom
QuentinBrosse:support-more-instance-errors

Conversation

@QuentinBrosse
Copy link
Copy Markdown
Contributor

@QuentinBrosse QuentinBrosse commented Dec 20, 2019

Converssions:

  • Error type invalid_request_error with fields field => InvalidArgumentsError
  • Error type invalid_request_error without fields field and with message field => ResponseError
  • Error type conflict => ResponseError

See errors_test.go for more details.

kindermoumoute
kindermoumoute reviewed Dec 23, 2019
View reviewed changes
Comment thread scw/errors.go
kindermoumoute
kindermoumoute requested changes Dec 23, 2019
View reviewed changes
Comment thread scw/errors.go Outdated
kindermoumoute
kindermoumoute approved these changes Dec 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit d93f0d4 into scaleway:master Dec 23, 2019
@QuentinBrosse QuentinBrosse deleted the support-more-instance-errors branch December 23, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuentinBrosse @kindermoumoute